fix: correct function name casing in IMP-002 conformance check - #18011
Merged
Conversation
…002) Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix casing in conformance check function name
fix: correct function name casing in IMP-002 conformance check
Feb 24, 2026
pelikhan
approved these changes
Feb 24, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a false positive in the IMP-002 conformance check by correcting the function name casing from computePermissionsForSafeOutputs (lowercase) to ComputePermissionsForSafeOutputs (uppercase) to match the actual exported Go function name.
Changes:
- Fixed grep pattern in IMP-002 check to use correct casing
ComputePermissionsForSafeOutputs - Updated comment to reflect the correct function name
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Smoke Test Results (Gemini)
Overall Status: FAIL
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IMP-002 conformance check in
scripts/check-safe-outputs-conformance.shwas grepping forcomputePermissionsForSafeOutputs(lowercasec), but the actual exported Go function isComputePermissionsForSafeOutputs(uppercaseC). This caused a permanent false HIGH failure.Change
scripts/check-safe-outputs-conformance.sh: Fix grep pattern casing to match the exported function nameOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.